Made isolatedModules always false#18
Merged
piotr-oles merged 1 commit intoTypeStrong:masterfrom Jun 7, 2017
johnnyreilly:master
Merged
Made isolatedModules always false#18piotr-oles merged 1 commit intoTypeStrong:masterfrom johnnyreilly:master
piotr-oles merged 1 commit intoTypeStrong:masterfrom
johnnyreilly:master
Conversation
…onfig.json without affecting typechecking
piotr-oles
approved these changes
Jun 7, 2017
Collaborator
|
Well done, thank you for your work :) I will add cross-env but not sure when - currently I'm a little bit busy :/ |
Member
Author
Believe me I understand 😄 BTW I've started the blog post - about half written so far. I'm planning to do one post that first covers using fork-ts-checker-webpack-plugin and then moves on to add happypack into the mix as well. (again using fork-ts-checker-webpack-plugin) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so it can be set to true in the tsconfig.json without affecting typechecking. I think it's as simple as this - do correct me if I'm wrong!
Resolves #17
BTW your build is *nix specific (the
NODE_ENV=testin thepackage.json). I haven't changed it but you could make it cross platform easily with cross-env